search

katyo / oboe-rs

Rust bindings for Oboe high-performance audio IO Android library
64 stars 22 forks source link

[WIP] [CI] Fix unsoundess #49

Closed katyo closed 1 year ago

torokati44 commented 2 years ago

I think removing the [patch.crates-io] section from Cargo.toml might help progressing the CI workflow. It did for me at least. Both glutin and winit have gained android support since those patches were added AFAIK.

See: https://github.com/katyo/oboe-rs/runs/8171082948?check_suite_focus=true#step:10:563

Rodrigodd commented 1 year ago

@katyo I think CI is failing because your APK_SIGN_KEY_DATA contain line breaks. I was hitting the same thing when I as trying it out.

katyo commented 1 year ago

@Rodrigodd Course, I added keystore to repo. Also I added rules to generate temporary keystore when no password provided to avoid issues with CI in forks.

katyo commented 1 year ago

@Rodrigodd Could you help me test this pr?

Rodrigodd commented 1 year ago

@katyo The demo appears to work okay, but one of my projects is crashing. I will investigate it, and try to find out where is the problem.

Rodrigodd commented 1 year ago

@katyo The problem was that I was actually running the project without the patch. With the patch applied everything is working fine.