katywarr / strengthening-dnns

Code repository to accompany the O'Reilly book: "Strengthening Deep Neural Networks: Making AI Less Susceptible to Adversarial Trickery"
https://learning.oreilly.com/library/view/strengthening-deep-neural/9781492044949/
MIT License
52 stars 22 forks source link

TensorFlow 2 Compatibility in /notebooks/chapter03/fashionMNIST_classifier.ipynb #7

Open christian-westbrook opened 2 years ago

christian-westbrook commented 2 years ago

Hello everyone! I'm currently working through this book as a part of my graduate studies, and I'm wondering if it would be okay if I adapted your examples for TF2 and maybe put them in a separate directory in the root of the project? I'm planning on running through all of the code here anyway using TF2, and so I wouldn't mind just committing what I have for you to review if you'd like?

The first issue I've found is in the initial fashionMNIST_classifier.ipynb script, where two minor changes achieve compatibility for TF2 without sacrificing the readability or flow of the author's original code. I'd be happy to fork and make a PR with small adjustments such as this in a dedicated TF2 directory, if that would be acceptable to the project authors.

katywarr commented 2 years ago

Hi Christian, Sorry for the slow response. Yes, I would be very happy to review/accept a PR and your approach sounds good. It would be great to have the project updated for TF2. Thank you for taking an interest in the code and for offering to do this. Katy