katz0018 / ecommerce-pattern-library

A term-long project redesigning an ecommerce website focusing on making a pattern library.
https://sleepy-swirles-8772b3.netlify.com/pattern-library/#brand
0 stars 0 forks source link

Hey Thomas, here is the form. #3

Closed katz0018 closed 5 years ago

katz0018 commented 5 years ago

Hey Thomas Ive been trying to make the forms turn only red if you try and submit without adding a required field but I think its not working. Do you think it's okay? I feel a little weird about it because on a form not everything is supposed to be highlighted but everything I included on the different forms are important.

@thomasjbradley

thomasjbradley commented 5 years ago

The fix, is that the CSS isn’t right—when you were writing the original CSS you added new CSS instead of replacing the CSS. So, delete these lines:


Also some improvements in the forms code: you don’t need the <!DOCTYPE>, etc.—only the fields.

Delete all this from all the form HTML files:


Do you intend to set all the fonts on your whole website to sans-serif? https://github.com/katz0018/ecommerce-pattern-library/blob/master/_patterns/forms/form.css#L1-L3