katz0018 / ecommerce-pattern-library

A term-long project redesigning an ecommerce website focusing on making a pattern library.
https://sleepy-swirles-8772b3.netlify.com/pattern-library/#brand
0 stars 0 forks source link

Hey Thomas, I tried adding the ingredients back in in. But did it do it correctly? are they working with the designated images? #5

Closed katz0018 closed 5 years ago

katz0018 commented 5 years ago

Hey Thomas I tried re adding the ingredients list but I'm not sure if I did it correctly and how can I check. Do I have to ask Annie to check? @thomasjbradley

thomasjbradley commented 5 years ago

Can you commit & push the code so I can have a look? It’s the quantity-form.html right?

katz0018 commented 5 years ago

Did it work? it shows like there is nothing else to commit and push. Yes quantity form.html

katz0018 commented 5 years ago

Also I heard about last night, CONGRATULATIONS! :)

thomasjbradley commented 5 years ago

@katz0018 Thanks!

I don’t see anything about ingredients in the code. Can you explain what you added?

katz0018 commented 5 years ago

I added ingredients in each product > .md file and I tried adding so that depending the products the ingredients list will change, but im not sure it worked.

katz0018 commented 5 years ago

Oh wait, I was in the wrong repository, maybe if you look now, it'll show up

katz0018 commented 5 years ago

ohhh no, terminal keeps saying :

Screen Shot 2019-03-28 at 10 03 46 AM

and won't let me look at my local host or anything :(

thomasjbradley commented 5 years ago

The ingredients in the products look okay. Try changing this line here: https://github.com/katz0018/ecommerce-pattern-library/blob/master/_patterns/forms/quantity-form.html#L19

Should be: {{include.ingredients}}

katz0018 commented 5 years ago

Did it work? Im not sure how I can see if its working.

thomasjbradley commented 5 years ago

The code looks okay. I don’t think there’s any way for you to test it right now. But Annie can test it out in her branch. (After she does the “update from master” thing.)