katz0018 / portfolio

The starter portfolio repository, basically empty, but with a few helper files.
https://agitated-villani-745d48.netlify.com
0 stars 0 forks source link

Erica Rios - peer review #5

Open Pinestorm opened 4 years ago

Pinestorm commented 4 years ago
0 points 1 points 2 points 3 points
Creativeness Bland, boring Fairly generic, but the colours are nice Good, works very well and is unique enough Wow! I never would have thought that would work so well!
Effectiveness I don’t know what this is trying to do The message isn’t completely clear and it’s difficult to use It’s obvious and simple to use The project is super effective and easy to use
Quality Non-existent Acceptable quality, more work could be done Good quality, up to the expectations of the teacher Stunning quality, this person rocks!
Effort Zero effort, incomplete Decent amount of effort Goodly amount of effort that shows Amazing, over-the-top amount of effort
Code quality Barely started Indentation is barely existent, lots of validation errors, very poor semantics Decent indentation, just a couple validation errors, decent semantics Well indented, fully valid, good semantics

I like your colours. Simple is better in some cases and the red and black goes together well. I also love your illustrations and I think they compliment your patterns nicely. Some issues I encountered were your responsiveness on smaller screen sizes, especially on your banners. When put down to the smallest screen size some elements begin to overlap on others. For example, your illustrations cover the headings.

2

Your card however, scales perfectly. Your library is at a great start but I feel you are able to add other things, maybe header and footer sections.