search

katzer / cordova-plugin-email-composer

Edit and send email messages
Apache License 2.0
344 stars 333 forks source link

Calling .open() crushes the app with targetSdk set to 30 on Android #374

Closed AliMariam closed 2 years ago

jfoclpf commented 2 years ago

Thank you very much @AliMariam for the PR, but according to the conversation in #372 (comment from @ahmad-alkhatib ) this does not seem to solve the problem

jfoclpf commented 2 years ago

@AliMariam Have you made tests yourself that this solves the problem?

AliMariam commented 2 years ago

yes @jfoclpf i have tested the solution on many devices in production mode , and it works perfectly


1. Samsung Galaxy A52S 5G , Android version : 12
2. Honor 8X, Android Version; 10
3. Huawei P30 Lite, Android Version; 10
4. HUAWEI Y5, Android Version;  8.2.0
5. Poco X3 Pro, Android : 12.1
6. Samsung Galaxy S20, Android 12
7. oppo a5s Android V8.1.0
8. HUAWEI Y5, Android Version;  8.0.0`
jfoclpf commented 2 years ago

Thanks @AliMariam , just a further question

did you test before and after this change? To be sure that this change you make solves the problem we're facing.

If not, could you kindly test again but without the change with Android 12, to be sure the crash really happens?

I'm saying this, because if we see no differences with the change, there's no need to change.

Thanks again for your cooperation

AliMariam commented 2 years ago

@jfoclpf I confirm that my test in android 12 was before and after update i made on the code

jfoclpf commented 2 years ago

Thanks @AliMariam merged accordingly then