katzer / cordova-plugin-local-notifications

Cordova Local-Notification Plugin
Apache License 2.0
2.56k stars 1.74k forks source link

compiler error #29

Closed HugoCornelis closed 10 years ago

HugoCornelis commented 10 years ago

Hi,

Great plugin. Worked well on my android emulator and device so far.

I believe I was hit with one of the bugs that was recently fixed, wrt notifications on Android when the app is running in the background.

So after upgrading the plugin with 'plugin rm' and then 'plugin add', I got the following error:

-compile: [javac] Compiling 18 source files to /home/hugo/neurospaces_project/jokes-on-you/source/snapshots/0/cordova/jokes-on-you/platforms/android/bin/classes [javac] /home/hugo/neurospaces_project/jokes-on-you/source/snapshots/0/cordova/jokes-on-you/platforms/android/src/de/appplant/cordova/plugin/localnotification/LocalNotification.java:213: non-static variable this cannot be referenced from a static context [javac] if (this.context == null) { [javac] ^ [javac] /home/hugo/neurospaces_project/jokes-on-you/source/snapshots/0/cordova/jokes-on-you/platforms/android/src/de/appplant/cordova/plugin/localnotification/LocalNotification.java:214: non-static variable this cannot be referenced from a static context [javac] this.context = context; [javac] ^ [javac] Note: /home/hugo/neurospaces_project/jokes-on-you/source/snapshots/0/cordova/jokes-on-you/platforms/android/src/org/apache/cordova/datepicker/Datepicker.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] 2 errors ', ' I am currently stuck.

Any idea?

Thanks for the help, thanks for a great plugin.

Hugo

HugoCornelis commented 10 years ago

I fixed this by replacing 'this.context' on lines 213 and 214 with 'LocalNotification.context'. This seems to work fine again after initial testing. Thanks again for this plugin. Hugo

katzer commented 10 years ago

I know... It was fixed immediately, but a bit to late (d275c40cb86d39c7880d4e8e0008216b8939b217)

As best upgrade the plugin from the master branch.