Closed MaZZly closed 9 years ago
Agree with @canda, this is really a Cordova 5/Cordova Android 4 issue, not necessarily crosswalk issue. His fix does work (no runtime errors I have seen yet), just need to also delete this jar to fix the compilation error: platforms/android/libs/android-support-v4.jar
Do the notifications work with the fix proposed by @canda ?
On Thu, Jun 18, 2015 at 9:47 AM, Dan J notifications@github.com wrote:
Agree with @canda https://github.com/canda, this is really a Cordova 5/Cordova Android 4 issue, not necessarily crosswalk issue. His fix does work (no runtime errors I have seen yet), just need to also delete this jar to fix the compilation error: platforms/android/libs/android-support-v4.jar
— Reply to this email directly or view it on GitHub https://github.com/katzer/cordova-plugin-local-notifications/issues/426#issuecomment-113181235 .
@bradmartin yup, just finished checking my app, notifications come in with all of the properties
@danda1man thanks! I'll use the fix then. Big thanks to @canda for the code.
Shouldn't be created a pull request to fix this, and create a new tag in the repository to be used with cordova 5?
Thank you @canda! for the code snipped. It all works now.
This Should really just be updated in a PR
not working i have a error cannot resolve method in this line webView.evaluateJavascript(js, null)
+1
+1
+1
+1
@canda fix works :)
+1
+1
+1
+1
+1
+1
Hi had a compliation error with @canda`s fix due to the method sendJavascript expecting only one argument and not the 2nd null parameter that was still left there. I've forked it and fixed it. if anyone is interested: https://github.com/moshetet/cordova-plugin-local-notifications
@canda's solution +1
Worked for me: https://github.com/sebasi/cordova-plugin-local-notifications on Cordova 5.4.1
@canda thank you so much your solution worked for me :) @sharifbdp thank you too for half solution;)
+1 We need a new release :P
how to end schedule notification after particular time(2 hours)??
+1
+1
Call native app from a web application and then get this error while tabbing back .... [ERROR: runtime_javascript_dialog_manager.cc(69) ] Not implemented reached in virtual void xwalk::RuntimeJavaScriptDialogmanager::ResetDialogState(content::WebContents*)
@darchanjo I am not surprised that sebasis's plugin compiles, since the relevant lines are just commented out: https://github.com/sebasi/cordova-plugin-local-notifications/blob/master/src/android/LocalNotification.java#L552 I would be surprised if the actual notifications fire through...
With crosswalk it doesn't compile if localnotification plugin is used.
I can get rid of compilation errors by removing the
sendJavascript
function inLocalNotification.java:463
and replacing the 2 calls to it (:419
&:454
) withwebView.sendJavascript(js);
Then it will compile.. Then when calling cancelAll() or scheduledIds() (And maybe others) the app crashes and output is:
[ERROR:runtime_javascript_dialog_manager.cc(69)] Not implemented reached in virtual void xwalk::RuntimeJavaScriptDialogManager::WebContentsDestroyed(content::WebContents*)
Ideas?