search

katzer / cordova-plugin-printer

Print HTML documents
Apache License 2.0
310 stars 284 forks source link

AndroidX #260

Open mrtungdev opened 3 years ago

rdlabo commented 3 years ago

@ImTung Thanks for awesome pull request. I get success to build android:

npm i cordova-plugin-printer@git@github.com:ImTung/cordova-plugin-printer.git

I'm looking forward to be merged this pull request.

johannesschobel commented 3 years ago

This PR needs to be merged ASAP!

johannesschobel commented 3 years ago

if you would like to use it directly within the package.json file, you can add this "temporary branch" as follows

{
  // ...
  "dependencies": {
    // ...
    "cordova-plugin-printer": "ImTung/cordova-plugin-printer",
  },
  "devDependencies": {
    // ...
  }
}
AltenTMAOrion commented 2 years ago

Up for merge this Pull Request

FawzyMokhtar commented 2 years ago

This PR should be merged ASAP..!

jonashger commented 2 years ago

This PR needs to be merged ASAP!

Romone183 commented 9 months ago

You still have to change the plugin.xml file

 <preference name="ANDROIDX_PRINT_VERSION" default="1.0.0"/>
        <framework src="androidx.print:print:$ANDROIDX_PRINT_VERSION" />
andreszs commented 5 months ago

Ground control to Major Katzer, do you hear me Major @katzer? This merge will fix cordova-android@10+ build errors. @