search

katzfuss-group / GPvecchia

Fast Gaussian-process inference using Vecchia approximations
19 stars 6 forks source link

LowRank functionality broken #38

Closed dzilber closed 5 years ago

dzilber commented 5 years ago

The command vecchia_specify(locs, m=10, conditioning = 'firstm') still does not work. I get the following error:

 Error in base::log(opts$J, 2) : 
  non-numeric argument to mathematical function 
3.  get.mra.params(n, mra.options, m) at mraNN.r#93
2.  findOrderedNN_mra(locsord, mra.options, m) at vecchia_specify.R#128
1.  vecchia_specify(locs, m, conditioning = "firstm")

I have been using an older version of the code for my simulations but there are have been many changes to code and my simulations need to be brought up to date.

marcinjurek commented 5 years ago

I'm on it, looks I'm able to reproduce the error.

marcinjurek commented 5 years ago

Seems like 409c126 fixed it on my end but please check. Also if you indicate that some bug is blocking you (even in the medium term), I'd be much more likely to address it more quickly!

dzilber commented 5 years ago

The fix works great, thank you! Will do ;)