createU doesn't work when we have independent blocks

katzfuss-group / GPvecchia

Fast Gaussian-process inference using Vecchia approximations

19 stars 6 forks source link

createU doesn't work when we have independent blocks #46

Closed marcinjurek closed 5 years ago

marcinjurek commented 5 years ago

Specifically, when for example r0 = c(0, 10), something is wrong in the line

LZinds[-Zinds] = 2*Ulatent@i

Note this happens when ic0 is used for the mra neighbourhood structure.

marcinjurek commented 5 years ago

@katzfuss how important would it be to fix that? The quick fix is to use the old algorithm in this case. But I looked into it and it seems that using ic0 is rather complicated. This is because we need to disentangle the NNarray and split it into several parts. Then do the ic0 for each part and put it together. It's certainly not impossible to do, but I'm not sure how important this feature is.