search

katzfuss-group / batram

Bayesian Transport Maps for non-Gaussian Spatial Fields
MIT License
4 stars 2 forks source link

Implements drawing multiple conditional samples with one function call #8

Closed wiep closed 1 year ago

wiep commented 1 year ago

Fixes #5

wiep commented 1 year ago

@danjdrennan, i forgot what we discussed last week. should i just merge this PR?

danjdrennan commented 1 year ago

I meant to look at this and discuss. It relates to a question I posed in the getting-started notebook... Whether we should return the field in the maxmin ordering or undo the ordering. I think I'm settling on the idea that we should return the maxmin-ordered sample and allow the user to postprocess the samples after they've been obtained. If you agree, then we should merge this and update the getting-started notebook to reflect that we've made a decision on it.

Code-wise this looks fine to me and I am fine with merging it.

wiep commented 1 year ago

We can think about returning an object that holds more than just the sample. Since we didn't do it so far, I didn't want to make the changes.