katzwebservices / Gravity-Forms-Directory

http://wordpress.org/plugins/gravity-forms-addons/
GNU General Public License v3.0
8 stars 3 forks source link

Fixes and Clean up #36

Closed shamalisulakhe closed 3 years ago

shamalisulakhe commented 3 years ago

Changes to-do

shamalisulakhe commented 3 years ago

Commit 1137f12

Changes done -

  1. Moved files to includes folder (need to think of admin folder yet, for admin files)
  2. Separated activation and deactivation functions in separate classes
  3. Separated shortcode functions in a separate class to reduce lengthy classes
  4. Introduced constants for version, plugin path, url, minimum GF version, etc.
  5. Added dependancy check (Check if GF is active and if not, deactivate the Directory plugin. This will reduce the need to check for GF at multiple instances.)
shamalisulakhe commented 3 years ago

Commit

shamalisulakhe commented 3 years ago

Commit

Fixed activation function and notice errors Tested address field Testing partial search issue #34

shamalisulakhe commented 3 years ago

Commit

andjules commented 3 years ago

THANK YOU SOOOOO MUCH for your hard and skilled work. I just installed this branch and it is working on a website I built for a church in Toronto around 3 years ago. I was the one who submitted issue #34 but we also realized the plugin was now breaking editability for all form entries since the latest update to Gravity Forms. You've made several people happy and grateful!

andjules commented 3 years ago

Awesome, thank you both