search

kaue / jsonexport

{} → :page_facing_up: it's easy to convert JSON to CSV
http://kaue.github.io/jsonexport/
Apache License 2.0
247 stars 41 forks source link

Issue #76 - Column values with zero (0) are being replaced with "" #77

Closed sregger closed 4 years ago

sregger commented 4 years ago

Status

READY/IN DEVELOPMENT/HOLD

Description

This fix is described by https://github.com/kaue/jsonexport/issues/76

Steps to Test or Reproduce

Noticed that on upgrading from 2.4.1 to 2.5.2 (and also 3.0.0) that the library has started to convert columns with integer values of 0 into "". To reproduce use jsonexport against data with a 0 value.

Impacted Areas in Application

List general components of the application that this PR will affect:

kaue commented 4 years ago

@sregger let me know when you are ok to merge this.

sregger commented 4 years ago

@kaue should be good to merge now

kaue commented 4 years ago

@sregger thanks so much for your contribution! :tada: I really hope you can help us with more contributions in the future :)

i will merge this into dev & publish the changes to npm today!

kaue commented 4 years ago

@sregger jsonexport 3.0.1 just got published with your fix!

sregger commented 4 years ago

Thank you @kaue I look forward to upgrading to it