kaungkhantsoe / NimbleTest

Technical Test for Nimble
1 stars 0 forks source link

Greeting and starting the reviewing process πŸ‘‹ #5

Open hoangnguyen92dn opened 2 years ago

hoangnguyen92dn commented 2 years ago

Hello Kaung Khant Soe,

Nice to e-meet you πŸ‘‹ and thanks for your effort on this submission. My name is Huey - an Android Developer at Nimble and I would like to conduct the feedback via Issue tickets regarding your performance here.

Keep in mind, this is a bidirectional process, so we would love to hear back from you as well, so please don’t hesitate to raise your question/correction in case we missed anything.

If we’re aligned on any issue here and you’d like to correct them, please go ahead and open a Pull Request per fix, merge it when you feel confident and we will follow up on those fixes πŸ˜‡

I hope you find the process enjoyable. Good luck and happy coding 🀘

kaungkhantsoe commented 2 years ago

Hello Huey, Nice to e-meet you too 😊. I am ready for the process and I will do my best for the fixes. Thank you for your time and efforts for reviewing the submission.πŸ˜‡

hoangnguyen92dn commented 2 years ago

@kaungkhantsoe I am finished my 1st round of code review πŸ˜„ Don't hesitate to lemme know if you have any concerns need to clarify. Regarding the time frame to resolve the created issues, you could follow up with our HR if you have your personal plan and need to deal with the deadline. πŸ˜„

β˜ƒοΈ Btw, Santa Claus is coming to town, Merry Christmas Eve! πŸŽ‰ πŸŽ…

kaungkhantsoe commented 2 years ago

@hoangnguyen92dn I've finished solving all the issues. Thank you for your time and pointing out the issues for me.

β˜ƒοΈ Merry Christmas Eve! πŸŽ‰

hoangnguyen92dn commented 2 years ago

@kaungkhantsoe Thanks for your updating. I will review the code changes and finalize my review of your challenge. Have a nice day β˜€οΈ

kaungkhantsoe commented 2 years ago

@hoangnguyen92dn Thank you. 😊