search

kauri-io / Content

A peer reviewed repository of content for kauri.io
12 stars 22 forks source link

Add Heroku Deployment Tutorial #70

Closed ghost closed 5 years ago

ghost commented 5 years ago

This PR will add a tutorial for deploying a dApp to Heroku per Issue #50.

It is currently a work in progress. I will ping again once it's ready for review. Feel free to provide any feedback you may have any time. Thanks!

ghost commented 5 years ago

Hey, @ChrisChinchilla, I just pushed what I think is a decent first draft. I one specific question at this point.

The only change to the code from the existing react project is the addition of a Procfile, which has just one line.

Is it worth creating a new project in the full stack dapp series repository? I thought it might be simpler to just say "add the Procfile to your existing project"; let me know if you agree.

I haven't gone through for edits yet but I'd also appreciate your feedback on tonality, length, detail, style, etc.

ghost commented 5 years ago

Hey @ChrisChinchilla, sorry to bother, just wondering if you have any feedback or change requests? Thanks!

ChrisChinchilla commented 5 years ago

@crawfordleeds Reviewing now. For the code component I'd say create a branch on the repo(https://github.com/kauri-io/kauri-fullstack-dapp-tutorial-series) and we direct people to that.

ghost commented 5 years ago

Just a couple of small things @crawfordleeds and then I will do a general edit for style and grammar. I haven't added a style guide yet, so don't expect you to have conformed to this. Then I'll merge and we can get it published and the bounty paid.

Thanks! Hope I didn't seem too pushy with my pings. I'll come back to this to finish up on your feedback in a few minutes.

ChrisChinchilla commented 5 years ago

@crawfordleeds Good stuff! I fixed some grammar and style. If you're happy I shall merge and if you can create an account on Kauri and publish.

ghost commented 5 years ago

@ChrisChinchilla thank you for the feedback. Everything looks great to me, let's merge it!

I just went ahead and published it, but couldn't quite figure out how to add it to part of the original series. Here's the link to the published article: https://kauri.io/article/a2e8c4a594344f7a951613a73f463fe7/v1/deploying-your-dapp-frontend-to-heroku.

Is there something I can do to move it within the series or is that something you have to do with admin privileges?