search

kaushalmall / aem-hotfix-installer

This utility automates the process of installing hotfixes on an AEM instance in the order specified.
Apache License 2.0
3 stars 0 forks source link

refactor: use threadpool #16

Closed kaushalmall closed 8 years ago

kaushalmall commented 8 years ago

@badvision looking for details from you on this one.

badvision commented 8 years ago

ThreadPoolExecutor should be created with a min and max size of 1. Using the execute method you can schedule work to be processed in order. This is ideal compared to other alternatives because you can pause or abort scheduled work more easily on an executor than if you were rolling your own thread. Also, the executor stats can be used to generate progress statistics as well.

badvision commented 8 years ago

Also make sure your source and target version are 1.8 so that your IDE can offer refactoring and suggestions to make the most use from method references and lambda expressions.

kaushalmall commented 8 years ago

@badvision look at this https://github.com/kaushalmall/aem-hotfix-installer/pull/20. Let me if this looks OK to merge

badvision commented 8 years ago

Should we close this issue now?

kaushalmall commented 8 years ago

yeah. It's done. Closing it