search

kaushalmodi / hugo-bare-min-theme

A bare minimum theme for Hugo (https://gohugo.io) to help develop and debug Hugo sites -- https://hugo-bare-min.netlify.com/,
https://hugo-sandbox.netlify.com/
MIT License
80 stars 16 forks source link

Update MathJax to v3 #9

Closed benide closed 5 years ago

benide commented 5 years ago

I used this tool to convert the config. Assuming this doesn't break any tests, this can close kaushalmodi/ox-hugo#297.

benide commented 5 years ago

It does seem to work with everything I had used it with before, but I'm finding there are some things I can improve on. Don't merge just yet!

benide commented 5 years ago

OK, the only things I can find wrong with this are already fixed over at the mathjax repo, but not in an official release yet. mathjax/MathJax#2186 is a little annoying but certainly not breaking. mathjax/MathJax-src#335 could be breaking for people using amsCd, but will be fixed in 3.0.1. Other than the first (non-breaking) bug I linked, I think nothing should change on your test site. Importantly, \ref{...} still works.

kaushalmodi commented 5 years ago

Thanks! Merging this.

kaushalmodi commented 5 years ago

Manually merged in https://github.com/kaushalmodi/hugo-bare-min-theme/commit/4958d996e3cc2c59d73b2c7d665105a64c7b24a5.