search

kaushalmodi / ox-hugo

A carefully crafted Org exporter back-end for Hugo
https://ox-hugo.scripter.co
GNU General Public License v3.0
867 stars 130 forks source link

straight quotes rendered as curved quotes in inline src blocks #640

Closed kaushalmodi closed 2 years ago

kaushalmodi commented 2 years ago

@pdcawley Or you can see this update ox-hugo test: https://ox-hugo.scripter.co/test/posts/inline-code-blocks/#using-custom-css-for-inline-src-blocks

Aside.. looks like we triggered a bug in Hugo.. the smart quotes rendering done by GoldMark happens inside the HTML code elements too!

image

See https://bug-smart-quote-conversion-in-code-element--hugo-mwe.netlify.app/posts/double-quotes-in-html-code-elements/

Originally posted by @kaushalmodi in https://github.com/kaushalmodi/ox-hugo/issues/638#issuecomment-1132911542

Upstream Issues:

kaushalmodi commented 2 years ago

@pdcawley Heads up! The required CSS will need to change as I adjust ox-hugo's export to implement a workaround for this limitation in Hugo's Commonmark parser.

kaushalmodi commented 2 years ago

Updated test: https://ox-hugo.scripter.co/test/posts/inline-code-blocks/#using-custom-css-for-inline-src-blocks

image

pdcawley commented 2 years ago

Cool!