search

kaushalmodi / ox-hugo

A carefully crafted Org exporter back-end for Hugo
https://ox-hugo.scripter.co
GNU General Public License v3.0
874 stars 132 forks source link

Fix regression: Org 9.6 breaks the title parsing for subtree-based export flow in many cases #688

Open kaushalmodi opened 1 year ago

kaushalmodi commented 1 year ago

This regression is caused by fixing a long-term bug that eventually got fixed in ox.el in Org 9.6. But that means that I need to undo the workaround for that bug in ox-hugo.

kaushalmodi commented 1 year ago

The regression is likely caused by this fix in Org: https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=927621910

The regressing behavior is that now the subtree post headings/titles get parsed from the wrong subtree!

image

kaushalmodi commented 1 year ago

@yantar92 I am copying you here just as an FYI.. just in case other export backends regress in the same way. I will fix this in ox-hugo.

yantar92 commented 1 year ago

Kaushal Modi @.***> writes:

@yantar92 I am copying you here just as an FYI.. just in case other export backends regress in the same way. I will fix this in ox-hugo.

I hope they not.

If anyone is reading this and considering putting a workaround for Org bugs, please consider reporting the bugs upstream first. Then, we will not need to deal with the situations like here where one needs to fix workarounds when Org fixes the actual bug.

-- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92

kaushalmodi commented 1 year ago

This issue should get fixed by https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0616b3c37

kaushalmodi commented 1 year ago

Revisit this once Org 9.6.1 is released: https://lists.gnu.org/r/emacs-orgmode/2023-01/msg00275.html

gregorybleiker commented 8 months ago

Is this really still open? I've spent hours trying to figure out why my subtitles aren't included in the posts. After all, the subtree-based approach is recommended in the readme. If this is broken, there should be a note there.