kaushikgopal / RxJava-Android-Samples

Learning RxJava for Android by example
Apache License 2.0
7.55k stars 1.37k forks source link

PseudoCacheMergeFragment: onNext now only adds the next 'contributor'… #73

Closed JimVercoelen closed 7 years ago

JimVercoelen commented 8 years ago

CashMergeFragment only adds the next contributor at a time instead of clearing & updating entire adapter for each next contributor.

kaushikgopal commented 7 years ago

heya thanks for this but the problem with this approach is that the previously added "stale" data remains in the list. if you spin up the example you'll notice both JW[0] and JW[800] in the list.

we could be smart and only update the results but that's why i went nuclear and just wiped the whole list and re-added :)

closing this for now. if you feel strongly that we should do this better, please feel free to reopen with changes to the PR, so stale date doesn't remain.