kaushikgopal / RxJava-Android-Samples

Learning RxJava for Android by example
Apache License 2.0
7.55k stars 1.37k forks source link

fix: observable leak in BG concurrency example #77

Closed kaushikgopal closed 8 years ago

kaushikgopal commented 8 years ago

issue #65 explains how to reproduce this and @marukami explains the reason for this happening beautifully.

given that we want to allow multiple clicks of the button, i think the right away to address this is just by using CompositeSubscriptions. In general, for android this also seems like the way to go.

67 is also a good potential fix, but i prefer going the CS route.

Seems more "semantic".