feat/rxjava_2 Retrofit related examples update to RxJava2

kaushikgopal / RxJava-Android-Samples

Learning RxJava for Android by example

Apache License 2.0

7.55k stars 1.37k forks source link

feat/rxjava_2 Retrofit related examples update to RxJava2 #84

Closed marcinkunert closed 7 years ago

marcinkunert commented 7 years ago

Migrated Retrofit related examples to RxJava2 Part of #83

marcinkunert commented 7 years ago

@kaushikgopal rebasing causes your commits to show up here. Any idea how to prevent this? I'm not too exprienced with PR's (only used "regular" git so far)

kaushikgopal commented 7 years ago

@marcinkunert - don't worry about it. i'll keep track when merging. since all of this is getting clubbed together in a single PR, that would eventually get merged to master, i'm not terribly concerned about it.

typically, i perform merges vs rebase's and that "keeps" the history, but that the history log tends to look nasty anyway ¯_(ツ)_/¯.

these PRs are granular enough where i don't think it should matter.

👍 thanks for the awesome work on all these