Add new parameters to ucm()

[timvink]

I would like to add two new parameters to the ucm() function. Specifically:

• tol. A tolerance parameter for SSModel on line https://github.com/kaushikrch/rucm/blob/master/R/ucm.R#L112
• method. The method used by fitSSM() on line https://github.com/kaushikrch/rucm/blob/master/R/ucm.R#L114

Not sure if package is still maintained.. if I make a merge request, will someone review it?

[kaushikrch]

Yes, please go ahead. The codes can be reviewed. On 2 Feb 2018 6:08 pm, "Tim Vink" notifications@github.com wrote:

I would like to add two new parameters to the ucm() function. Specifically:

• tol. A tolerance parameter for SSModel on line https://github.com/kaushikrch/rucm/blob/master/R/ucm.R#L112 https://github.com/kaushikrch/rucm/blob/master/R/ucm.R#L112
• method. The method used by fitSSM() on line https://github.com/kaushikrch/rucm/blob/master/R/ucm.R#L114 https://github.com/kaushikrch/rucm/blob/master/R/ucm.R#L114

Not sure if package is still maintained.. if I make a merge request, will someone review it?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kaushikrch/rucm/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/AHNwBABIxRyrw_zHv6qF-9JLKLJ3DH6Oks5tQwHhgaJpZM4R3H_E .

[timvink]

Great, here's the MR: https://github.com/kaushikrch/rucm/pull/11