search

kaushikrch / rucm

Implementation of Unobserved Components Models (UCM) in R
3 stars 3 forks source link

Out of sample predict #12

Closed timvink closed 6 years ago

timvink commented 6 years ago

Hi kaushikrch,

My colleagea Gilles Verbockhaven and I made an edit to RUCM to be able to predict out of sample. This would close issues #2 and #8 .

Could you have a look and merge if you like it?

Kind regards,

Tim

timvink commented 6 years ago

Hi kaushikrch,

Have you had a chance to look at this yet? Looking forward :)

Tim

kaushikrch commented 6 years ago

Apologies, had been caught up with work. Will take a look over the weekend.

On Thu, Mar 22, 2018 at 2:15 PM, Tim Vink notifications@github.com wrote:

Hi kaushikrch,

Have you had a chance to look at this yet? Looking forward :)

Tim

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kaushikrch/rucm/pull/12#issuecomment-375220538, or mute the thread https://github.com/notifications/unsubscribe-auth/AHNwBFmb-zJomhySDs30zXujW-mvaxDbks5tg2TGgaJpZM4SotHV .

kaushikrch commented 6 years ago

Thanks Tim and Gilles.

timvink commented 6 years ago

Thanks. FYI, looks like the update to the README wasn't merged though.

timvink commented 6 years ago

Update: the actual update to predict.ucm() is also not updated yet. Perhaps something went wrong with the merge.. shall I open another pull request?

kaushikrch commented 6 years ago

Probably that would be helpful. I think something went wrong while merging.

On Mon, Mar 26, 2018 at 6:19 PM, Tim Vink notifications@github.com wrote:

Update: the actual update to predict.ucm() is also not updated yet. Perhaps something went wrong with the merge.. shall I open another pull request?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kaushikrch/rucm/pull/12#issuecomment-376153971, or mute the thread https://github.com/notifications/unsubscribe-auth/AHNwBDsb-oh-fh1qIa_NBv4WT6sVIu11ks5tiOPVgaJpZM4SotHV .