Closed richelbilderbeek closed 3 years ago
Hi
Thanks for the suggestion, I agree that it would be useful to be able to avoid having to invoke GCAE from the project directory.
Do you think it is important to be able to have the train_opts, data_opts and models in custom locations on the system, or would it work equally well to keep requiring them to be in the GCAE directory and re-writing the paths to be relative to project directory using e.g. (in run_gcae.py)
from pathlib import Path
GCAE_DIR = Path(__file__)
and assuming data_opts/ train_opts/ and models/ are in GCAE_DIR
Yay, thanks for appreciating my suggestion!
I think your suggestion is great and I look forward to using it :-)
Dear GenoCAE maintainer,
Here I suggest to to allow a user to run GCAE from any folder, instead of forcing him/here to work from the GenoCAE folder.
When running the 'training' example code from the GenoCAE folder, the training works awesome:
Here I run the command:
Here is part of the result:
However, when I work from another folder, say, one folder up ...
I get an error message that
"data_opts/" + data_opts_id+".json"
cannot be found, at here in the code:The problem here is the hardcoded
"data_opts/"
part, that forces me to work in the same folder as GenoCAE. It feels clumsy to work with, as I have to change the working directory when calling GenoCAE. Note that, looking at the code, the same applies fortrain_opts
andmodels
.I would enjoy a way to either (my favorites are first :-) ):
--data_opts_folder
CLI argument, code becomesdata_opts_folder + "data_opts/" + data_opts_id+".json"
, or--data_opts myfolder/b_0_4.json
, code becomesdata_opts
(which is now a filename), or--datadir
(data_dir + "/" + data_opts_id+".json"
), orWould one of these options be doable?