search

kausmees / GenoCAE

Convolutional autoencoder for genotype data
BSD 3-Clause "New" or "Revised" License
15 stars 10 forks source link

Suggest + volunteer: text files are not executable #12

Closed richelbilderbeek closed 3 years ago

richelbilderbeek commented 3 years ago

Dear GenoCAE maintainers,

Thanks for the example code and examples, I find these very useful!

What is unexpected, however, is that somehow the genetic input files in the folder example_tiny are set to be executables, as can be seen in the screenshot of my terminal (see below, green indicates an executable) and by the File Manager asking me to run a text file when I open it (see below, at the right-hand side):

Screenshot from 2021-06-29 11-52-12

I guess a chmod +x was messed up somewhere :-)

I suggest to remove the executable flag of these simple text files.

I volunteer to do so.

kausmees commented 3 years ago

This is indeed very stange, please do remove the executable flag.

Thanks!

richelbilderbeek commented 3 years ago

Cool, will do so!

(BTW, I suggest to keep the Issue open as long as it is not fixed or rejected: it is the common GitHub workflow)

richelbilderbeek commented 3 years ago

Pull Request at #14 :-)

richelbilderbeek commented 3 years ago

Screenshot to prove that works:

Screenshot from 2021-06-29 12-46-58