Suggestion: set default of maxP to NULL

kaustubhad / fastman

An R package for fast and efficient visualizing of GWAS results using Q-Q and Manhattan plots directly from PLINK output files.

GNU General Public License v3.0

36 stars 8 forks source link

Suggestion: set default of maxP to NULL #14

Open mja opened 1 year ago

mja commented 1 year ago

Current biobank and meta-GWAS are well-powered enough that almost all will contain a P-value smaller than 1e-14, so there isn't a single value that is sensible default for truncating the Y axis. This PR sets maxP=NULL as the default.

mja commented 1 year ago

Maybe also this parameter could have a different name since the value it accepts is interpreted as -log(P) and would also depend on the value of the logp argument.