Code documentation

[142ayushkumar]

Closes #11

[kaustubhhiware]

Please do not consider that your work was incorrect because so many suggestions were made. Most of the work is improving upon the original idea after suggestions are made.

Cheer up and take feedback positively :smiley:

[kaustubhhiware]

That was quick ! I'll let others also review and approve this, before merging in.

[kaustubhhiware]

@Demfier the commits should have been squashed before merging. Only one thing was added. So one change per commit. Please revert and only merge after @142ayushkumar has squashed the commits.

[Demfier]

@kaustubhhiware Ok, instead of reverting, I am removing those commits from master. A new PR with squashed commits would be better than reverting. What do you say?

[142ayushkumar]

i did this : git rebase -i HEAD~5 but i can't see any difference

[kaustubhhiware]

I'll try doing it then in some time.

On 11-Dec-2017 2:19 PM, "Kumar Ayush" notifications@github.com wrote:

i did this : git rebase -i HEAD~5 but i can't see any difference

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kaustubhhiware/c0derunR/pull/29#issuecomment-350658941, or mute the thread https://github.com/notifications/unsubscribe-auth/AKy1F7yDRo3k4zwK8ppINlgwcQWVVeKJks5s_OyMgaJpZM4Q8MVt .

[kaustubhhiware]

No, a new pr will be unnecessary. I'll fix it in some time.

[kaustubhhiware]

@Demfier seems that was the only option :confused:

@142ayushkumar please send your changes from a separate branch again. Sorry for the inconvenience.

Please make sure all changes are in 1 commit only.

[142ayushkumar]

Here: #31