search

kaustubhhiware / c0derunR

An attempt at a cleaner UI for online IDE's: http://c0derunr.herokuapp.com
MIT License
21 stars 8 forks source link

Updated youtube video link #37

Closed kaustubhhiware closed 6 years ago

kaustubhhiware commented 6 years ago

This is a test for #33

Demfier commented 6 years ago

At last! What is the issue in deploying? Any config issue?

On Dec 19, 2017 6:44 PM, "Kaustubh Hiware" notifications@github.com wrote:

This is a test for #33 https://github.com/kaustubhhiware/c0derunR/issues/33

You can view, comment on, or merge this pull request online at:

https://github.com/kaustubhhiware/c0derunR/pull/37 Commit Summary

  • Updated youtube video link (what is love)

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kaustubhhiware/c0derunR/pull/37, or mute the thread https://github.com/notifications/unsubscribe-auth/AMAyBnIfe0IsH_6EbE760CHIbadX6wGjks5tB7aogaJpZM4RG8e9 .

kaustubhhiware commented 6 years ago

I'm checking the log in heroku, seems it is downloading Django-2.0, not the mentioned version. I'll check how to use requirements.txt instead of just downloading it straight away

kaustubhhiware commented 6 years ago

@Demfier I'll be opening some more PR's to just check if auto-deploy works or not

kaustubhhiware commented 6 years ago

See this. The app is deployed, but isn't any good.

https://c0derunr-pr-37.herokuapp.com/

Demfier commented 6 years ago

@kaustubhhiware - Is heroku local web successful?

Demfier commented 6 years ago

Also, try pip install -r requirements.txt in beta-test branch and then the heroku push origin beta-test if you haven't

kaustubhhiware commented 6 years ago

Umm, the whole idea is once a PR is made, the pipeline should automatically create a review app. As a contributor, I should not have the burden of dealing with heroku at all.

kaustubhhiware commented 6 years ago

heroku local web runs perfectly.

The only problem is it tries to install Django 2, not Django 1.11 as specified in requirements.txt (newest commit in master)

kaustubhhiware commented 6 years ago

@Demfier sucess at last ! Auto-deploy works perfectly.

To make auto-deploy work, a branch must be made atleast from the current master (at 95ea0e8)

kaustubhhiware commented 6 years ago

To just make sure it works without interference, closing this PR and making a brand new fresh PR with same changes.