search

kauzlari / sympler

SYMPLER: SYMbolic ParticLE simulatoR
GNU General Public License v3.0
15 stars 15 forks source link

Dummy Walls #32

Closed janmees closed 7 years ago

janmees commented 7 years ago

Removes need for Dummy Walls in ParticleCreatorFile when used to create particles outside of stl geometry.

janmees commented 7 years ago

I also changed pos.peek() = 33 to pos.peek() = '!' to be more readable.

kauzlari commented 7 years ago
  1. Please merge your master with mine in your repo. Then, after testing that everything still works, either check that this pull request is still valid and contains the merge, or create a new pull request.
  2. I think it is time to add a test to the code, of the features that you added. Please check directory testsuite for that. You only have to add a complete test-input in testsuite/TSTIN/ and a reference output (created by the input) in testsuite/RESULTS. Note the naming rules! And note that the run should not take longer than 5 seconds. So, take one of your examples and reduce it (fewer particles, timesteps) such that it fulfils these needs. The test should at least contain your new Boundary module and PCWall using your new feature. Run the testsuite including your new test with test_sympler.pl while being in the testsuite directory. Probably the first test (part_with_fluid) will fail, but if it fails with tiny differences, then this is OK.