search

kav2k / fl_favourites

Playing Favourites for Fallen London
MIT License
8 stars 11 forks source link

Delay first sync to cloud #15

Closed kav2k closed 5 years ago

kav2k commented 7 years ago

When a new instance of the extension is installed, it MAY happen that a race condition between default options being set in local and real options being received from sync result in clobbering of the storage by default values.

It seems unlikely in extension-installed-by-extension-sync scenario, but may happen in development. And I don't like losing my settings!

Chrome storage sync mechanisms are a bit of a mess, but at least this can be partially mitigated by disallowing local->sync transfer within a short time after extension is launched. That way, sync has a chance to receive actual values and write them over the local storage.

janinko commented 6 years ago

Any update on this?

kav2k commented 6 years ago

According to #16 this can happen in regular use scenario. A solution is needed more urgently.

janinko commented 6 years ago

yup it happend to me about 3 times, every time I used browser on new PC

kav2k commented 6 years ago

Unfortunately, I haven't used the extension myself in a while, because I stopped playing FL. Duly noted that the bug is quite bad. I'll try to fix this as a priority.