upgrade to latest scala version, add fx:info section

kavedaa / sbt-javafx

JavaFX plugin for SBT

36 stars 6 forks source link

upgrade to latest scala version, add fx:info section #5

Closed janlisse closed 11 years ago

janlisse commented 11 years ago

I made 2 small enhancements:

upgrade to latest scala version 2.10.1
addition of a fx:info section in the generated ant build file -> this allows native packagers to properly set vendor/title etc..

kavedaa commented 11 years ago

Thanks, that looks good.

Is there a good reason for having some of the fields as Options? Otherwise I think they should empty strings by default, since they end up as that in the build file anyway, and it makes it easier for the user not to have to remember to wrap those specific values in a Some.

janlisse commented 11 years ago

I just followed the description of the fx:info element where vendor and title are mandatory and the other params optional. But you are right. From the user perspective it's better to remove the Options and provide empty Strings as default. Already changed that in the pull request.