Simpler logic for centering camera.

kawa-kokosowa / sappho

2D Game Library

http://sappho.lillian.link/

MIT License

15 stars 1 forks source link

Simpler logic for centering camera. #65

Closed kawa-kokosowa closed 8 years ago

kawa-kokosowa commented 8 years ago

Hoping for some review of these changes. I simplified the centering logic (at least I find it easier to read) and it seems to work in Python 2, and since it's not using any division I presume the same for Python 3.

coveralls commented 8 years ago

Coverage decreased (-0.03%) to 91.054% when pulling 4fdb07af8e039992e788a67e1a8bef894b36600f on camera-fix into f1ef0af47fd6f30fabf83433a0a5df6d50f27f2b on master.

kcsaff commented 8 years ago

Well, this feels like cheating :P But looks good! 👍 👍 👍

kawa-kokosowa commented 8 years ago

Oh I should probably update tests...

ghost commented 8 years ago

Hah, I completely forgot that Rects have a center property. LGTM. :+1: