kawadhiya21 / mysql-migrations

A tool to use with mysql package to maintain migrations
MIT License
31 stars 25 forks source link

Please leave logging a user's choice #18

Open mmben opened 3 years ago

mmben commented 3 years ago

Hi, I just updated my application from 1.0.6 to 1.0.7 and then back down again, because of the console logs that have been added in PR #15 .

We faced the same desire to be able to log what has actually been migrated. Since this package lacks the possibility we simply made a diff of the migrations table before and after running it and logged it.

Version 1.0.7 seem to even log the migrations SQL-Statements which clutters up our output. I know no other library that logs to console just like that. I also think from a security point of view, this is not a good idea at all, because I don't want to expose database internals via the console output.

Please add a possibility to opt-out of these console logs or reconsider them. We would welcome a better possibility to log what migration has been executed, but rather by API than by console log.