search

kawadhiya21 / mysql-migrations

A tool to use with mysql package to maintain migrations
MIT License
31 stars 25 forks source link

Lower the length of timestamp column #8

Closed perenstrom closed 3 years ago

perenstrom commented 6 years ago

If a database has a limit of 1000 bytes for indexes, the timestamp column will in utf8 be too long and throw an error when trying to create the migration table. This suggested change lowers the limit to 64, which should be more than enough for this field.

perenstrom commented 6 years ago

This should perhaps even be changed to an int field.

kawadhiya21 commented 6 years ago

Will you be interested to be a collaborator of this repository? Pls give your email address if you are interested.

perenstrom commented 6 years ago

Possibly, what would that entail exactly?

kawadhiya21 commented 6 years ago

You will have ownership rights for this repository. You can merge code, update the package, add new features. I will also provide npm access to update the npm package as well.

perenstrom commented 6 years ago

I think I'll pass. I don't have the time I'm afraid. I'll keep doing PR's when I find something.

perenstrom commented 5 years ago

Is there a reason why this has not been merged yet?

perenstrom commented 4 years ago

A year has passed, still no info on why you don't just merge it?