search

kawaiiDango / pano-scrobbler

Scrobbles to last.fm, ListenBrainz, libre.fm, GNU FM, Maloja, Pleroma or to a file, on Android
https://kawaiidango.github.io/pano-scrobbler/
GNU General Public License v3.0
1.14k stars 31 forks source link

Premium features for donation and F-droid releases #229

Open mjholub opened 2 years ago

mjholub commented 2 years ago

Would be nice if there was a way to access premium features without gApps, since Aurora Store unfortunately doesn't support purchasing new apps so I have to use a secondary smartphone or my PC, whilst I'm also a bit hesitant to give Google my CC data. The simplest way I can think of achieving it is if there was a possibility to get an unique key available after donating via ko-fi.

Oh, and since the app is licensed under GPL, it could be published on F-droid, possibly there can be a dedicated package without Google Crashlytics and this way of obtaining premium features as the only one available. Instead, since people who use F-Droid are mostly techies, stack trace could be generated and the app would suggest sending an e-mail with it. It may also be necessary to try replacing ACRCloud with (AcoustID)[https://acoustid.org/]. If you don't have the time to create separate releases for F-droid, I can try becoming a maintainer.

Efreak commented 2 years ago

Regarding fdroid, see #2 and #216. I just added pScrobbler to my automated fdroid repo, which will pull new github releases daily. However, I believe @kawaiiDango includes nonfree libs in the releases, so up to you if you want to install. According to one of those issues, the app does work with microg (I use Gapps, so I can't tell you if it works without).

mjholub commented 2 years ago

I also use microG. The thing is it connects to Crashlytics servers, though they can be blocked with Nebulo, pihole, etc. And that other library for scrobbling from mic, which has a libre alternative. Perhaps in July I'll have the time to make and test a more libre build and share the results here.

mjholub commented 2 years ago

I also use microG. The thing is it connects to Crashlytics servers, though they can be blocked with Nebulo, pihole, etc. And that other library for scrobbling from mic, which has a libre alternative. Perhaps in July I'll have the time to make and test a more libre build and share the results here.

15 Jun 2022 02:22:58 Efreak @.***>:

Regarding fdroid, see #2[https://github.com/kawaiiDango/pScrobbler/issues/2] and #216[https://github.com/kawaiiDango/pScrobbler/issues/216]. I just added pScrobbler to my automated fdroid repo[https://github.com/efreak/auto-daily-fdroid], which will pull new github releases daily. However, I believe @kawaiiDango[https://github.com/kawaiiDango] includes nonfree libs in the releases, so up to you if you want to install. Anything to one of those issues, the app does work with microg (I use Gapps, so I can't tell you if it works without).

— Reply to this email directly, view it on GitHub[https://github.com/kawaiiDango/pScrobbler/issues/229#issuecomment-1155836851], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AUVF6RFSN3VF6PA2BSI4XK3VPEO6BANCNFSM5X43LOOA]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AUVF6RGNR2UJU2AHSWBQS6DVPEO6BA5CNFSM5X43LOOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOITSKXMY.gif]

lostb053 commented 1 year ago

So is there no other way for me to get premium features?

freshgum-bubbles commented 1 year ago

Yeah, I'm agreeable to this. If there was a way to support the app without Google Play, that'd be a lot better.

I'm not sure what F-Droid's terms on pay-gates are (cc @IzzySoft), but -- as a very regular user of Pano -- with the clear amount of effort put into this app I'd be very happy to pay a fair amount for it ;-)

It goes without saying that the alternative method wouldn't be included in the Play Store builds, though -- against their policies, from what I understand.

kawaiiDango commented 3 months ago

So I made a proof of concept JWT based key generator, mailer and a license checking server, just out of curiosity. It is far from complete as of now. But in future, I might provide a way for ko-fi donors who have donated above a certain amount, to get a key to unlock premium features for the app downloaded from GitHub or the custom f-droid repo (which in turn downloads from GitHub releases).

IzzySoft commented 3 months ago

@freshgum-bubbles apologies, missed your ping back then – but received one for the last comment… So: the suggested approach should be fine – as long as the entire app is open-source. F/LOSS does not mean "must be free as in free beer", but "must be libre" – see The Four Essential Freedoms of Free Software.

kawaiiDango commented 3 months ago

IzzySoft, refer to this comment, https://github.com/kawaiiDango/pano-scrobbler/issues/2#issuecomment-1099163793

If I were to create a non play store build, all of those non free dependencies wont make sense anymore and will be removed, except Acrcloud (since it provides a very useful feature).

But this repo is not buildable as it is. The files containing API keys and other secrets have been gitignored. This will be an issue for Izzy's automated builds.

IzzySoft commented 3 months ago

The files containing API keys and other secrets have been gitignored. This will be an issue for Izzy's automated builds.

Yupp, they'd be. But there are options to it. First let me state two "existing facts":

Building on these two facts: you could "camouflage" the keys, e.g. encoding the keys (or their entire config files) using base64 – and then decode that at build-time to create those files/keys. That way they'd still be "out of plain sight", but all builders could handle it easily. Needless to say this does NOT go for the signing keys. Those are only needed by you: our verification builders do not need them, and whoever else wants to build for themselves should also sign for themselves anyway.