Voice module on stock board does not initialise in time

kawal547 / open9x

Automatically exported from code.google.com/p/open9x

0 stars 0 forks source link

Voice module on stock board does not initialise in time #109

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

With stock board and voice module, when nologo option selected, there is not 
enough time for the voice module to initialise.
So the first message does not play. Especially throttle warning,switch warning 
or mON voice.

Can we display centered text "Open9x" instead of logo for one second for stock 
board with nologo and voice options?

Original issue reported on code.google.com by mho...@gmail.com on 23 Aug 2012 at 8:11

GoogleCodeExporter commented 8 years ago

Original comment by bson...@gmail.com on 27 Aug 2012 at 1:41

Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 8 years ago

confirmed. without splash, first message does not play. 
tested on stock board r1292. and there is not enough flash for splash with 
voice and other useful options on stock.

Original comment by gbir...@gmail.com on 27 Aug 2012 at 9:42

GoogleCodeExporter commented 8 years ago

Original comment by bson...@gmail.com on 27 Aug 2012 at 9:47

Added labels: Type-Defect
Removed labels: Type-Enhancement

GoogleCodeExporter commented 8 years ago

One second is not enough, 1,5s works good, so 2s should be safe value.

Original comment by mho...@gmail.com on 28 Aug 2012 at 7:23

GoogleCodeExporter commented 8 years ago

And these 2 seconds MUST be skipped if the Tx rebooted. I write it to be sure I 
think of it ...

Original comment by bson...@gmail.com on 28 Aug 2012 at 7:25

Changed state: Started

GoogleCodeExporter commented 8 years ago

They must be skipped too if proto=DSM and we're trying to bind!

Original comment by bernet.a...@gmail.com on 28 Aug 2012 at 7:34

GoogleCodeExporter commented 8 years ago

Indeed, it will come inside this branch:

if (!UNEXPECTED_SHUTDOWN) {
...
}

Original comment by bson...@gmail.com on 28 Aug 2012 at 7:36

GoogleCodeExporter commented 8 years ago

Original comment by bson...@gmail.com on 28 Aug 2012 at 7:37

GoogleCodeExporter commented 8 years ago

Original comment by bson...@gmail.com on 28 Aug 2012 at 10:40

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

I just reviewed the code I ported from er9x and I see that there is already an 
initialization time of 1.2seconds.
in stock/voice.cpp:

else if (VoiceState == V_STARTUP) {
    if (g_blinkTmr10ms > 120) // Give module 1.2 secs to initialise
    {
      VoiceState = V_IDLE;
    }
  }

As I prefer what Mike did, I will commit a new change, with my previous change 
reverted and 200 there instead of 120.
Would you try it?

Original comment by bson...@gmail.com on 28 Aug 2012 at 12:41

Changed state: Started

GoogleCodeExporter commented 8 years ago

Original comment by bson...@gmail.com on 29 Aug 2012 at 1:07

Changed state: Fixed