System crash when selecting new model that has switch warnings

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Create a model with switch warnings set
2. Switch to a different model
3. Set at least one switch so that the switch warning will display for the 
first model in step 1.
4. Use MODELSEL menu to select the model created in step 1.

Note that the switch warning display appears briefly, before a system reboot. 
(WDT reset, presumably.)

5. reset the switch so that no warning will appear. Selection now works without 
crash.

Note that, once selected, the switch warning as issued at power-up works OK 
with no crash.

This is happening in r1195 as well as current trunk (r1269).

PCBV4, avr-gcc 4.5.1 (OS X)

Original issue reported on code.google.com by gru...@gmail.com on 24 Aug 2012 at 2:44

[GoogleCodeExporter]

At first I thought this fault my be related to having DSM2 serial running. But 
I've tested also using selection between two freshly created standard 4-ch PPM 
models and I see the same problem.

Original comment by gru...@gmail.com on 24 Aug 2012 at 2:46

[GoogleCodeExporter]

If I am right, the fix I did this morning solved the issue! If no, please 
reopen the issue, thanks!

Original comment by bson...@gmail.com on 27 Aug 2012 at 1:40

• Changed state: Fixed

[GoogleCodeExporter]

Just tested r1298. Problem still exists. I noticed last night that it happen 
with even the throttle warning screen, too. Strange.

Original comment by gru...@gmail.com on 28 Aug 2012 at 3:18

• Changed state: Started

[GoogleCodeExporter]

For sure the problem comes because of the call to:

if (pulsesStarted()) {
  pausePulses();
}

When loading a model in pulses_avr.cpp

What are your compilation options? Perhaps with DSM2 things change...

Original comment by bson...@gmail.com on 28 Aug 2012 at 6:18

[GoogleCodeExporter]

If I am right the system crashes only if you load a DSM2 model and you compiled 
with DSM2=SERIAL. Would you confirm this information?

Original comment by bson...@gmail.com on 28 Aug 2012 at 6:34

[GoogleCodeExporter]

Original comment by bson...@gmail.com on 28 Aug 2012 at 6:44

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by gru...@gmail.com on 28 Aug 2012 at 12:43

• Changed state: Verified

[GoogleCodeExporter]

By the way, I never did check about the DSM2=SERIAL thing. Problem is 
definitely solved in that case. Here are my complete build options used to 
verify this issue resolution, just in case anyone ever wants to cross reference 
...

make PCB=V4 EXT=FRSKY HELI=YES TEMPLATES=YES AUTOSWITCH=YES DBLKEYS=YES \
         AUDIO=YES HAPTIC=YES DECIMALS=NO SDCARD=YES DSM2=SERIAL \
         EEPROM_PROGRESS_BAR=YES

Original comment by gru...@gmail.com on 28 Aug 2012 at 1:07