kawal547 / open9x

Automatically exported from code.google.com/p/open9x
0 stars 0 forks source link

delta offsets for Telemetry #174

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Which board (stock / gruvin9x / sky9x) are you using? Stock

What is your open9x FW version? 1772

What is your open9x EEPROM version? 211-3

What steps will reproduce the problem?
1. in custom switches set delta offsets, d>ofs or |d|>ofs 
2. chose Dist, Galt, Curr, Cnsp or Powr
3. values are  adjustable only from -127 to +127

What is the expected output?
For Dist, Galt, Curr, Cnsp or Powr deltas have the same range like for "v" 
offsets. (or only bigger than +/-127)

Please provide any additional information below.
Thanks

Original issue reported on code.google.com by gbir...@gmail.com on 29 Dec 2012 at 10:43

GoogleCodeExporter commented 8 years ago
Done. To be tested!

Original comment by bson...@gmail.com on 19 Jan 2013 at 10:43

GoogleCodeExporter commented 8 years ago
Thanks,
looks good, tested and playing some voices on delta change :)

just minor spacing when there are negative values eg. Dist, GAlt and Consp. But 
in this cases I don't expect to use 4 digits negative values.

Original comment by gbir...@gmail.com on 21 Jan 2013 at 8:22

Attachments:

GoogleCodeExporter commented 8 years ago
Right, I think I will let it as it is (or there will be a pb with km/h) ...

Original comment by bson...@gmail.com on 21 Jan 2013 at 8:28

GoogleCodeExporter commented 8 years ago
We can save one char space by changing v1,v2 and ofs to column names A,B

#define LEN_VCSWFUNC     "\007"
#define TR_VCSWFUNC      "---\0   ""A>B\0   ""A<B\0   ""|A|>B\0 ""|A|<B\0 
""AND\0   ""OR\0    ""XOR\0   ""A=B\0   ""A!=B\0  ""A>B\0   ""A<B\0   ""A>=B\0  
""A<=B\0  ""dA>=B\0 ""|dA|>=B"

What do you think?

Original comment by mho...@gmail.com on 23 Jan 2013 at 1:03

GoogleCodeExporter commented 8 years ago
Absolutely, this is an excellent idea. It will save flash, but indeed space on 
LCD! Would you take care of it?

Original comment by bson...@gmail.com on 23 Jan 2013 at 1:15

GoogleCodeExporter commented 8 years ago
I can do it, thanks.

Original comment by mho...@gmail.com on 23 Jan 2013 at 1:46

GoogleCodeExporter commented 8 years ago
+ 1
Maybe kmh will fit too. It was truncatted  before. 

Original comment by gbir...@gmail.com on 23 Jan 2013 at 9:37

GoogleCodeExporter commented 8 years ago

Original comment by mho...@gmail.com on 25 Jan 2013 at 6:00

Attachments:

GoogleCodeExporter commented 8 years ago
Excellent, thanks!

Original comment by bson...@gmail.com on 26 Jan 2013 at 11:49