kawal547 / open9x

Automatically exported from code.google.com/p/open9x
0 stars 0 forks source link

Input Filter selection not visible on Transmitter menu #184

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Which board (stock / gruvin9x / sky9x) are you using?
stock

What is your open9x FW version?
r1855

What is your open9x EEPROM version?
212-1

What steps will reproduce the problem?
1. press left long to enter General Settings on Transmitter
2. on first page press down key 
3. after the sound options, I expected the Input Filter option, but it is not 
there. 

What is the expected output? What do you see instead?
The expected output should be an menu item called "Input Filter" with the 
options Single, Oversample and Filter.
Instead of this, this menu item is missing. Also in the other pages no such 
settings can be found.

Please provide any additional information below.
Interestingly the option is available in Windows program companio9x.
And this option actually works if you alter it on the PC and load the settings 
afterwards to the transmitter.

Original issue reported on code.google.com by open.20.fsguruh@xoxy.net on 27 Jan 2013 at 1:00

GoogleCodeExporter commented 8 years ago
This option has been removed in new versions.
This part of the code has been reworked (Issue 164)

Original comment by mho...@gmail.com on 27 Jan 2013 at 7:00

GoogleCodeExporter commented 8 years ago
Right. Romolo removed the input filter option from c9x today

Original comment by bson...@gmail.com on 27 Jan 2013 at 7:09

GoogleCodeExporter commented 8 years ago
First I want to say, thank you for doing all of this. It's nearly perfect in 
every kind. Also how you handle issues reports, etc. very professional.

Please let me r comment on this topic.
I tried to understand a little bit the rework based on issue 164. As far as I 
understand you reduced the latency a lot, which is really good.
On the other side, the original meaning from er9x (I think it's the branch 
which invents this option) the input filter option also increases the 
resolution.
I still see the higher resolution, because the output values have a digit more 
if the option is enabled. That's why I think it is still working, even not 
visible.
So in the output display you see 100,0 instead of just 100. 
The simulator in companion9x does not show this difference.
Are you really sure the old mechanism is removed?
What is about the resolution in the new mechansism. Quite interesed.

Original comment by open.20.fsguruh@xoxy.net on 27 Jan 2013 at 8:20

GoogleCodeExporter commented 8 years ago
The new inpu system is in my opinion the best we will able to have on the 9x. 
The "filtered" option was completely wrong. The "oversampled" option was the 
best. So it's the one we choosed at the time. The latency is not increased as 
described in issue 164.

Original comment by bson...@gmail.com on 27 Jan 2013 at 9:28

GoogleCodeExporter commented 8 years ago
Also update documentation.

Actually true I checked again, and there is no difference, whatever you choose 
in companion9x. Please also update the documentation, which still explains ADC 
Filter options, which are no longer there and add the information open9x always 
uses OSMP option as explained in er9x. 
I used in former times (last year) also er9x and choose that option, so I am 
very happy with this decision you did.
I look forward for the next version of open9x, especially the backlight dimm 
option, hopefully included.
Great work, please continue. Btw, I thought I found a donation button, but 
can't find them anymore, where is it?

Original comment by open.20.fsguruh@xoxy.net on 27 Jan 2013 at 10:01

GoogleCodeExporter commented 8 years ago
Right I asked to make donations to MSF. But it's true that now I need to buy 
some sensors, so a donation will be welcome ;) You will find a link in 
companion9x help dialog.

Original comment by bson...@gmail.com on 27 Jan 2013 at 10:07

GoogleCodeExporter commented 8 years ago
Done, hopefully worked and helps you to buy whatever needed to continue. Please 
do not forget stock configuration in future.
Thanks again and please continue...

Original comment by open.20.fsguruh@xoxy.net on 28 Jan 2013 at 6:28