kawamataryo / copy-git-link

Provides a shortcut to copy permalink in their online Git repositories.
https://plugins.jetbrains.com/plugin/17756-copy-git-link
25 stars 13 forks source link

Android Studio Arctic Fox (2020.3.1) support #2

Closed mallowlabs closed 2 years ago

mallowlabs commented 2 years ago

Hi. Thank you for developing an awesome plugin!

I'm an Android developer. I use Android Studio and I want to use this copy-git-link plugin.

But Android Studio is based on old IntelliJ platform. For example, the latest stable release "Android Studio Arctic Fox (2020.3.1) Patch 3" is based on 203.7717.56. (ref: https://zenn.dev/kafumi/articles/3d01174cee8715 )

Can you change pluginSinceBuild to 203? I checked that it works on "Android Studio Arctic Fox (2020.3.1) Patch 3" with changed pluginSinceBuild version.

arctic-fox
kawamataryo commented 2 years ago

@mallowlabs

Wow ! mallowlabs san !! Thanks for using my plugin XD. I fixed to pluginSinceBuild to 203.*

https://github.com/kawamataryo/copy-git-link/commit/e28d1cd776ec0f9fa9ddf53429a930b61ae7c874

But. failed the pre-release review.

Screen Shot 2021-12-05 at 5 41 11

It seems that the methods used notifications are not compatible with older versions. We will fix it at the end of the year, so please wait a while 🙏

mallowlabs commented 2 years ago

@kawamataryo

Thank you for your challenge!

It seems that the methods used notifications are not compatible with older versions.

It is a bad news 😢

We will fix it at the end of the year, so please wait a while 🙏

If it breaks the current behavior, you don't have to change supporting versions. I can wait the new version of Android Studio!

Thanks in advance 😄

mallowlabs commented 2 years ago

I have good news and bad news.

The good news is that Android Studio Bumblebee is released! It is based on IntelliJ platform2021.1.1(pluginSinceBuild is 211)

The bad news is that I still cannot install copy-git-link to Android Studio Bumblebee. Could you challenge to change pluginSinceBuild to 211? I hope that the compatibility problem is solved 🙏

kawamataryo commented 2 years ago

I had missed the message. Sorry for the late reply 🙏

I will try again to change PluginSinceBuild.

kawamataryo commented 2 years ago

@mallowlabs

Sorry I'm really late! Changed pluginSinceBuild to 211.* in ver 0.3.2. Please try it 👍

https://plugins.jetbrains.com/plugin/17756-copy-git-link/versions/stable/163400

mallowlabs commented 2 years ago

@kawamataryo

Thank you for your work!

However I cannot install 0.3.2 to my Android Studio (Bumblebee) 😢

The version is below:

version

The error message is below:

error

I tried to make a patch. When I removed the wildcard from pluginSinceBuild, the install was succeeded locally.

diff --git a/gradle.properties b/gradle.properties
index 1e51fbe..af00ca8 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -7,7 +7,7 @@ pluginVersion = 0.3.2

 # See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
 # for insight into build numbers and IntelliJ Platform versions.
-pluginSinceBuild = 211.*
+pluginSinceBuild = 211
 pluginUntilBuild = 221.*

 # Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl

But I don't understand the reason. 🤔

kawamataryo commented 2 years ago

Sorry I didn't check 🙏

Thanks for the patch !! I will try to apply again with pluginSinceBuild: 211 🚀

kawamataryo commented 2 years ago

I'm sorry... Since I changed the build, it still failed in the marketplace public review due to compatibility issues...

I am now contacting Jetbrains slack and support. Please wait.

image

mallowlabs commented 2 years ago

Thank you for your hard work 😢

If it breaks the current behavior, you don't have to change supporting versions yet. I can wait the next version of Android Studio!

kawamataryo commented 2 years ago

@mallowlabs

I contacted Jetbrains support and found a solution 👍

v 3.3 is now available. You should be able to install that one with Android Studio. Please try it!

image

mallowlabs commented 2 years ago

@kawamataryo

I installed copy-git-link to Bumblebee successfully! You accelerated my team productivity. Thank you!!