kawamataryo / sky-follower-bridge

Instantly find and follow the same users from your X(Twitter) follower on Bluesky.
https://chrome.google.com/webstore/detail/sky-follower-bridge/behhbpbpmailcnfbjagknjngnfdojpko
MIT License
445 stars 13 forks source link

Extension is now asking read/write permission on all websites? #36

Closed u1735067 closed 9 months ago

u1735067 commented 9 months ago

Hello,

it seems the latest version(s?) (0.8.0) is now asking read/write permission on all websites, is that expected? Previously it was only asking for the websites set in https://github.com/kawamataryo/sky-follower-bridge/blob/84a522c8c06442d6110e0bfb7925ab32e84ecfa0/package.json#L52-L57

Best,

ShawnBowman commented 9 months ago

Yep I'm seeing this too. The extension got auto-disabled because of it and I'm concerned about turning it back on.

kawamataryo commented 9 months ago

I didn't change the permissions...why is that?

https://github.com/kawamataryo/sky-follower-bridge/blob/main/package.json#L53-L57

I'll look into it.

kawamataryo commented 9 months ago

This is the difference in the generated manifest.json from the previous version.

CleanShot 2024-01-24 at 04 51 35

The addition of web_accessible_resources may be the cause of this issue..

kawamataryo commented 9 months ago

I will try to fix it so that it does not need unnecessary permissions.

kawamataryo commented 9 months ago

I found that either a bug in the build tool or an unnecessary web_accessible_resources permission was introduced and this was the cause of this Issue.

Fixed in the following commit.

https://github.com/kawamataryo/sky-follower-bridge/commit/2721ee92568bf0b0d19b7433f94649c03c94468c (Not a good way to...)

Unnecessary permissions will no longer be required with the 0.8.1 release.

kawamataryo commented 9 months ago

8.1 was released, but not fixed...😢 I will try to fix again.

kawamataryo commented 9 months ago

I fixed it again in version 8.2.

image

u1735067 commented 9 months ago

Fixed for me, thanks, and thank you for the extension too btw 😊