search

kawamuray / wasmtime-java

Java or JVM-language binding for Wasmtime
Apache License 2.0
128 stars 29 forks source link

added arch to dynamic library name #44

Closed krisbitney closed 1 year ago

krisbitney commented 1 year ago

I added the system arch to the dynamic library file name. Arch is found using System.getProperty("os.arch"). This fetches the architecture of the JVM running the java code.

This will make it easier to add additional JNI builds in the future, and avoid name conflicts when the architectures differ but the os is the same.

Note that I can't test this on my local machine because the master branch doesn't build.

Execution failed for task ':compileJava'.
> java.lang.IllegalAccessError: class lombok.javac.apt.LombokProcessor (in unnamed module @0x64c9ad8b) cannot access class com.sun.tools.javac.processing.JavacProcessingEnvironment (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.processing to unnamed module @0x64c9ad8b
kawamuray commented 1 year ago

oops, somehow I missed this PR notification, sorry. If you closed this assuming I was not interested in this, and still want this to get in, please re-open. I'm positive for the change.