search

kawamuray / wasmtime-java

Java or JVM-language binding for Wasmtime
Apache License 2.0
128 stars 29 forks source link

Implement custom config #5

Closed SuperIceCN closed 3 years ago

SuperIceCN commented 3 years ago

implement custom config for Config.class, Store.class and Engine.class in both java and rust.

SuperIceCN commented 3 years ago

@kawamuray Is there any problems left?

kawamuray commented 3 years ago

Oh sorry, I thought your work is still in progress. Next time, please click the "re-request review" button to avoid such misunderstanding... I'll take a another look at this PR today.

image
kawamuray commented 3 years ago

Left just an another comment. and can you also try git rebase onto master branch as I suggested in the previous comment?

SuperIceCN commented 3 years ago

Left just an another comment. and can you also try git rebase onto master branch as I suggested in the previous comment?

@kawamuray emm, it seems that I made I mistake that I pushed the previous commits again ... I dont know what to do actually. git rebase seems do nothing

kawamuray commented 3 years ago

What supposed to be done is git rebase -i origin/master and pick only commits that are intended for this PR. Well, I can do "squash and merge" so it won't clutter commit history so it's just a matter of the better commit message which simply concatenate all commits' messages. Let me merge this as-is this time then :)

kawamuray commented 3 years ago

LGTM, thanks 👍

kawamuray commented 3 years ago

hm.. printDouble.wasm included again, but anyway.