search

kawane / songbook

Kawane's Songbook
http://kawane.github.io/songbook
Apache License 2.0
3 stars 2 forks source link

Using http://undertow.io/ instead of vertx #23

Closed llgcode closed 9 years ago

llgcode commented 9 years ago

Vertx is a great framework but it seems that we don't need a framework like this. Vertice and module are too much for our purpose and we don't really understand these abstraction. Undertow is smaller than vertx and has a similar async API, we need to port the code for the Server part and SongDatabase part that intensivly use vertx. For this work it's preferable to make a branch cause for now songbook is stable and usable with vertx.

jeancharles-roger commented 9 years ago

+1

jeancharles-roger commented 9 years ago

There is a working version using undertow in the undertow branch (0dc8df6239164a87bf1e6e77bc722b686e235b7f). Maybe it's time to merge ?

llgcode commented 9 years ago

Ok thanks

-- Laurent.

On 24 April 2015 at 18:01, Jean-Charles Roger notifications@github.com wrote:

There is a working version using undertow in the undertow branch (0dc8df6 https://github.com/kawane/songbook/commit/0dc8df6239164a87bf1e6e77bc722b686e235b7f). Maybe it's time to merge ?

— Reply to this email directly or view it on GitHub https://github.com/kawane/songbook/issues/23#issuecomment-95978231.

jeancharles-roger commented 9 years ago

I've merged it (needed to advance to build the app).

llgcode commented 9 years ago

Yes! Le 24 avr. 2015 22:21, "Jean-Charles Roger" notifications@github.com a écrit :

Closed #23 https://github.com/kawane/songbook/issues/23.

— Reply to this email directly or view it on GitHub https://github.com/kawane/songbook/issues/23#event-289636731.