search

kay-is / react-from-zero

A simple (99% ES2015 less) tutorial for React
https://www.fullstackreact.com/react-from-zero/
GNU General Public License v2.0
4.6k stars 405 forks source link

Introduce Class method notation plus some Cleanups #29

Closed j-m-hoffmann closed 6 years ago

j-m-hoffmann commented 6 years ago

introduces Class method notation in 10-example-app.html and applies it consitently throughout the other files.

cheers

kay-is commented 6 years ago

Thanks for the work, the cleanups are appreciated.

I'd like to keep the ifs instead of the switch and I'd try to avoid ES2015, which method notation is. If you could remove these changes I would merge :)

Sorry that can't merge everything.

j-m-hoffmann commented 6 years ago

closing this since i opened two PRs with the desired fixes. Great lesson though, one change per pull request.