search

kayagoban / shadowlands

A Dapp platform and Ethereum terminal, entirely in Python.
MIT License
144 stars 10 forks source link

support for passphrase in Trezor 1.0 #3

Closed fccoelho closed 6 years ago

fccoelho commented 6 years ago

Hi I tried connecting my Trezor 1.0 but I encoutered an error because I have a passphrase configured on my Trezor besides the numeric code. It seems that Shadowlands don't expect this and crashes with an AttributeError.

kayagoban commented 6 years ago

Ah, yes, it would - there’s no support for that feature yet on the Trezor. It can only handle the PIN so far.

On Oct 12, 2018, at 7:47 AM, Flávio Codeço Coelho notifications@github.com wrote:

Hi I tried connecting my Trezor 1.0 but I encoutered an error because I have a passphrase configured on my Trezor besides the numeric code. It seems that Shadowlands don't expect this and crashes with an AttributeError.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

kayagoban commented 6 years ago

I'll add a line to the README.md to warn people about that. Unknown when I'll be getting to this, but we'll leave the issue open.

fccoelho commented 6 years ago

Good Idea. It's actually easy to turn off passphrase security on the trezor wallet. That way trezor users can have a nice first experience with shadowlands.

Em sex, 12 de out de 2018 10:42, Chuck Thomas notifications@github.com escreveu:

I'll add a line to the README.md to warn people about that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kayagoban/shadowlands/issues/3#issuecomment-429329728, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIjWw-S23mSLsci8itLmVNUWp5QkuVyks5ukJwrgaJpZM4XZaET .

carver commented 6 years ago

This ended up being a dealbreaker for me to try it out. :-/

My Trezor is stuck on the screen "Please enter your passphrase..." and a stacktrace with AttributeError: address is smashed across the asciimatics screen.

kayagoban commented 6 years ago

Sigh. It’s painful to me, how the Trezor requires the user interface to take part in authentication. The passphrase feature is particularly puzzling to me - if I trust that nobody is keylogging me, then why do I need a credstick?

I think I probably will have to implement this for the upcoming alpha release.

On Oct 16, 2018, at 3:42 PM, Jason Carver notifications@github.com wrote:

This ended up being a dealbreaker for me to try it out. :-/

My Trezor is stuck on the screen "Please enter your passphrase..." and a stacktrace with AttributeError: address is smashed across the asciimatics screen.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

kayagoban commented 6 years ago

Fixed in the shadowlands-core repo by https://github.com/kayagoban/shadowlands-core/commit/b3dbcda11132471ac48a76052c22dc3677de4961

The alpha release of shadowlands will include this fix.