Fix strict mode failure + fix .bind not defined in IE7

kayahr / console-shim

Browser console compatibility shim for legacy JavaScript engines

MIT License

86 stars 16 forks source link

Fix strict mode failure + fix .bind not defined in IE7 #3

Closed dmp42 closed 12 years ago

dmp42 commented 12 years ago

Strict mode doesn't allow defining named functions out of global scope or top block of functions. Assigning wrap as an anonymous function fixes this.

Also, wrap.bind obviously is not defined in IE7 (and other browsers not support Function.prototype.bind). Changing the way the methods are wrapped fixes this.

buildhive commented 12 years ago

Klaus Reimer » console-shim #5 SUCCESS This pull request looks good (what's this?)

dmp42 commented 12 years ago

Thank you, gentle build bot :)

FWIW, I ran the tests in:

IE7, IE8, IE9 (from IE9 dev tools on windows 7)
Firefox 2.0 (on OSX)
latest Opera, Safari, Chrome (on OSX)

Unrelated: it seems that log4javascript fails at formatting strings.

buildhive commented 12 years ago

Klaus Reimer » console-shim #6 SUCCESS This pull request looks good (what's this?)

kayahr commented 12 years ago

Sorry for the late reaction. Strict mode and bind is now fixed.

dmp42 commented 12 years ago

Thanks!