Decorators in utils do not preserve function signature

kayak / pypika

PyPika is a python SQL query builder that exposes the full richness of the SQL language using a syntax that reflects the resulting query. PyPika excels at all sorts of SQL queries but is especially useful for data analysis.

http://pypika.readthedocs.io/en/latest/

Apache License 2.0

2.43k stars 293 forks source link

Decorators in utils do not preserve function signature #717

Open DavideWalder opened 1 year ago

DavideWalder commented 1 year ago

Decorators such as https://github.com/kayak/pypika/blob/6128a67aae1508588a338e852bb67153a92aae50/pypika/utils.py#L39 do not preserve the original function signature. For example, anything after a select statement is untyped.

Possible solutions:

use the wraps
Use simple type vars to specify inputs and outputs of Callable
Python 3.10 only: use ParamSpec if more complex behaviour is required